From 8e600c679c4d49acc1b044a678acb922f2b0f995 Mon Sep 17 00:00:00 2001
From: Michele Cereda <cereda.michele@gmail.com>
Date: Sun, 18 Aug 2024 22:45:11 +0200
Subject: [PATCH] fix(ansible): follow linting suggestions

---
 .ansible-lint                           | 3 ++-
 .ansible-lint-ignore                    | 5 +++--
 examples/ansible/ec2.clone-instance.yml | 2 +-
 snippets/ansible/tasks.yml              | 2 +-
 4 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/.ansible-lint b/.ansible-lint
index a2beb60..052bbfe 100644
--- a/.ansible-lint
+++ b/.ansible-lint
@@ -3,5 +3,6 @@
 
 offline: true
 warn_list:
-  - 'role-name[path]'
+  - 'name[template]'   # Jinja templates should only be at the end of 'name' -- oh come on!
+  - 'role-name[path]'  # Avoid using paths when importing roles -- yeah, need for testing
   - package-latest
diff --git a/.ansible-lint-ignore b/.ansible-lint-ignore
index 35f46a1..55abe6a 100644
--- a/.ansible-lint-ignore
+++ b/.ansible-lint-ignore
@@ -1,2 +1,3 @@
-ansible/playbooks/keybase.register-device.yml                   no-changed-when
-examples/ansible/aws_ec2.yml                                    yaml[comments-indentation]
+ansible/playbooks/keybase.register-device.yml  no-changed-when
+examples/ansible/aws_ec2.yml                   yaml[comments-indentation]
+examples/ansible/ec2.clone-instance.yml        args[module]
diff --git a/examples/ansible/ec2.clone-instance.yml b/examples/ansible/ec2.clone-instance.yml
index b8b86e3..fc569bd 100644
--- a/examples/ansible/ec2.clone-instance.yml
+++ b/examples/ansible/ec2.clone-instance.yml
@@ -12,7 +12,7 @@
       amazon.aws.ec2_instance_info:
         filters:
           "tag:Name": "{{ original_instance_name_tag }}"
-          "instance-state-name": [ "running" ]
+          "instance-state-name": ["running"]
       register: original_instance_information
     - name: Check a running instance with Name tag '{{ original_instance_name_tag }}' has been found
       tags:
diff --git a/snippets/ansible/tasks.yml b/snippets/ansible/tasks.yml
index 1d9b085..2839c4a 100644
--- a/snippets/ansible/tasks.yml
+++ b/snippets/ansible/tasks.yml
@@ -424,7 +424,7 @@
           amazon.aws.ec2_instance_info:
             filters:
               "tag:Application": K8S
-              "instance-state-name": [ "running" ]
+              "instance-state-name": ["running"]
         - name: Clone EC2 instances
           vars:
             source_instance_id: i-0123456789abcdef0